Conversation
read index files into maps for list and rm commands
|
Code Climate has analyzed commit b251cfd and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 40.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.2% (-0.5% change). View more on Code Climate. |
jkrech
reviewed
Mar 5, 2025
Member
jkrech
left a comment
There was a problem hiding this comment.
I took the window binary from the action build for a test:
cpackget list -p
cpackget add TexasInstruments::MSPM0H321X_DFP -R ./myPacks
These commands work as expected after the most recent changes.
I can confirm that installing a pack file or registering a pdsc file does no longer update the index.pidx file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… packs are concerned
Fixes
#404
Changes
most sources and tests
Checklist