Skip to content

issue #404, moved download of index.pidx after decision if only local…#469

Merged
jkrech merged 6 commits intomainfrom
issue-404
Mar 7, 2025
Merged

issue #404, moved download of index.pidx after decision if only local…#469
jkrech merged 6 commits intomainfrom
issue-404

Conversation

@bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Feb 27, 2025

… packs are concerned

Fixes

#404

Changes

most sources and tests

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@jkrech jkrech requested review from brondani and soumeh01 February 28, 2025 06:37
@bgn42 bgn42 requested a review from jkrech February 28, 2025 15:49
bgn42 added 2 commits March 4, 2025 14:14
read index files into maps for list and rm commands
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit b251cfd and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 40.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.2% (-0.5% change).

View more on Code Climate.

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the window binary from the action build for a test:

cpackget list -p
cpackget add TexasInstruments::MSPM0H321X_DFP -R ./myPacks

These commands work as expected after the most recent changes.

I can confirm that installing a pack file or registering a pdsc file does no longer update the index.pidx file.

I ask @brondani and @soumeh01 to review the code.

Copy link
Collaborator

@soumeh01 soumeh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit a31392f into main Mar 7, 2025
19 of 20 checks passed
@jkrech jkrech deleted the issue-404 branch March 7, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants