Skip to content

read old index.pidx to obtain URL before using the default#540

Merged
jkrech merged 2 commits intomainfrom
indexURL
Jun 11, 2025
Merged

read old index.pidx to obtain URL before using the default#540
jkrech merged 2 commits intomainfrom
indexURL

Conversation

@bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Jun 11, 2025

Fixes

  • try first the URL of existing index.pidx before using the default at keil.com

Changes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Jun 11, 2025

Diff Coverage: The code coverage on the diff in this pull request is 30.0%.

Total Coverage: This PR will decrease coverage by 0.06%.

File Coverage Changes
Path File Coverage Δ Indirect
cmd/installer/root.go -0.2
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@bgn42 bgn42 requested a review from jkrech June 11, 2025 12:08
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit 61fecad into main Jun 11, 2025
22 of 23 checks passed
@jkrech jkrech deleted the indexURL branch June 11, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants