Skip to content

Issue #541, showing wrong error info fixed#542

Merged
jkrech merged 3 commits intomainfrom
issue_541
Jun 12, 2025
Merged

Issue #541, showing wrong error info fixed#542
jkrech merged 3 commits intomainfrom
issue_541

Conversation

@bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Jun 12, 2025

Fixes

#541

Changes

depending on the version modifier an error or info is shown. For installations with "any version" only an info is shown with viersion(s) which are installed

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Jun 12, 2025

Diff Coverage: The code coverage on the diff in this pull request is 60.0%.

Total Coverage: This PR will decrease coverage by 0.01%.

File Coverage Changes
Path File Coverage Δ Indirect
cmd/installer/root.go -0.3
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@bgn42 bgn42 requested review from Copilot and jkrech June 12, 2025 10:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #541 by ensuring the correct log message (error or info) is displayed based on the pack's version modifier.

  • Adds new tests for version list generation and updated semantic version comparison ranges.
  • Introduces a new utility function VersionList in semver.go to format version strings.
  • Updates logging in the installer to show version lists for packs with "any version".

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
cmd/utils/semver_test.go Added new tests for version range comparison and version listing.
cmd/utils/semver.go Added the VersionList utility function to process version strings.
cmd/installer/root.go Updated logging to correctly display version information based on the version modifier.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit 0a6da55 into main Jun 12, 2025
23 checks passed
@jkrech jkrech deleted the issue_541 branch June 12, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants