while adding, show a warning only if there is a .pdsc too deep but al…

[bgn42]

…so one in a correct level

Fixes

Changes

• make additional check loop in verifying a pack when adding

Checklist

• 🤖 This change is covered by unit tests (if applicable).
• 🤹 Manual testing has been performed (if necessary).
• 🛡️ Security impacts have been considered (if relevant).
• 📖 Documentation updates are complete (if required).
• [xx] 🧠 Third-party dependencies and TPIP updated (if required).

[qltysh]

Diff Coverage: The code coverage on the diff in this pull request is 84.7%.

Total Coverage: This PR will increase coverage by 0.02%.

File Coverage Changes

Path	File Coverage Δ	Indirect
cmd/installer/pack.go	-1.1

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[jkrech]

LGTM

[Copilot]

Pull Request Overview

This PR improves the validation logic for PDSC files when adding CMSIS packs. The change enhances the pack validation process to show warnings instead of errors when a pack contains a valid PDSC file at the correct level alongside additional PDSC files that are too deep in the folder structure.

• Refactored the validation loop to collect all valid PDSC files before making decisions
• Added logic to show warnings for additional deep PDSC files when valid ones exist at correct levels
• Introduced new error types for multiple PDSC files and wrong PDSC names

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
cmd/installer/pack.go	Restructured pack validation logic to handle PDSC files more intelligently with warning/error prioritization
cmd/errors/errors.go	Added two new error types for multiple PDSC files and wrong PDSC file names

Comments suppressed due to low confidence (1)

cmd/installer/pack.go:277

• [nitpick] The variable name file is too generic and shadows the loop variable from the earlier iteration. Consider renaming it to pdscFile or validPdscFile for clarity.

	file := validPdscFiles[0]