Skip to content

[packchk] Validate <url> starts with https:// #1109 (#1139)#1961

Merged
edriouk merged 8 commits intoOpen-CMSIS-Pack:mainfrom
ARM-software:outbound/urlIsHttps_1109
Feb 13, 2025
Merged

[packchk] Validate <url> starts with https:// #1109 (#1139)#1961
edriouk merged 8 commits intoOpen-CMSIS-Pack:mainfrom
ARM-software:outbound/urlIsHttps_1109

Conversation

@spcaipers-arm
Copy link
Collaborator

@github-actions
Copy link

github-actions bot commented Feb 12, 2025

Test Results

  6 files   12 suites   8s ⏱️
 41 tests  41 ✅ 0 💤 0 ❌
123 runs  123 ✅ 0 💤 0 ❌

Results for commit fe15ba9.

♻️ This comment has been updated with latest results.

@grasci-arm grasci-arm force-pushed the outbound/urlIsHttps_1109 branch from 5f610a2 to 494646b Compare February 12, 2025 15:17
@edriouk edriouk merged commit 3779afa into Open-CMSIS-Pack:main Feb 13, 2025
27 checks passed
@edriouk edriouk deleted the outbound/urlIsHttps_1109 branch February 13, 2025 11:03
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.46%. Comparing base (331b229) to head (fe15ba9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../packchk/test/integtests/src/PackChkIntegTests.cpp 72.22% 1 Missing and 4 partials ⚠️
tools/packchk/src/CheckFiles.cpp 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1961      +/-   ##
==========================================
+ Coverage   65.43%   65.46%   +0.03%     
==========================================
  Files         173      173              
  Lines       35061    35094      +33     
  Branches    20364    20380      +16     
==========================================
+ Hits        22941    22975      +34     
+ Misses       7906     7901       -5     
- Partials     4214     4218       +4     
Flag Coverage Δ
packchk-cov 68.28% <81.81%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/packchk/include/CheckFiles.h 100.00% <ø> (ø)
tools/packchk/src/CheckFiles.cpp 69.12% <93.33%> (+1.38%) ⬆️
.../packchk/test/integtests/src/PackChkIntegTests.cpp 68.90% <72.22%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants