Skip to content

Conversation

@jkrech
Copy link
Member

@jkrech jkrech commented Jul 1, 2025

fix: #2128

@jkrech jkrech requested a review from brondani July 1, 2025 12:58
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

Test Results

  7 files   53 suites   4m 54s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 156996f.

♻️ This comment has been updated with latest results.

brondani
brondani previously approved these changes Jul 1, 2025
Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we apply the same changes to other supported compilers?

@jkrech jkrech requested a review from brondani July 1, 2025 13:29
@jkrech
Copy link
Member Author

jkrech commented Jul 1, 2025

Very valid point. I have updated it for the other compilers as well.

Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit 57988df into main Jul 1, 2025
32 checks passed
@jkrech jkrech deleted the fix-mapfile-with-space-in-path branch July 1, 2025 16:01
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (0b67240) to head (156996f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2129   +/-   ##
=======================================
  Coverage   65.90%   65.90%           
=======================================
  Files         181      181           
  Lines       37220    37220           
  Branches    21658    21658           
=======================================
  Hits        24531    24531           
  Misses       8240     8240           
  Partials     4449     4449           
Flag Coverage Δ
buildmgr-cov 73.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCC build fails when path contains blank character

3 participants