-
Notifications
You must be signed in to change notification settings - Fork 63
fix map file with space in path for GCC #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 7 files 53 suites 4m 54s ⏱️ Results for commit 156996f. ♻️ This comment has been updated with latest results. |
brondani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we apply the same changes to other supported compilers?
|
Very valid point. I have updated it for the other compilers as well. |
brondani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2129 +/- ##
=======================================
Coverage 65.90% 65.90%
=======================================
Files 181 181
Lines 37220 37220
Branches 21658 21658
=======================================
Hits 24531 24531
Misses 8240 8240
Partials 4449 4449
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
fix: #2128