Skip to content

strip optional Pname from load#227

Merged
jkrech merged 10 commits intomainfrom
strip_pname
Sep 23, 2025
Merged

strip optional Pname from load#227
jkrech merged 10 commits intomainfrom
strip_pname

Conversation

@jkrech
Copy link
Member

@jkrech jkrech commented Sep 19, 2025

Fixes

Changes

strips optional Pname in case of multi-core device being selected.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@jkrech jkrech requested a review from Copilot September 19, 2025 12:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes device name parsing for multi-core STM32 devices by stripping optional Pname components from the load command. The change addresses issue #226 by improving how device identifiers are processed when they contain vendor, Dname, and optional Pname components.

Key changes:

  • Enhanced device string parsing to handle vendor::Dname:Pname format
  • Strips optional Pname component to use only Dname for the load command
  • Maintains backward compatibility for simpler device name formats

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jkrech jkrech requested review from bgn42 and Copilot September 19, 2025 13:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jkrech
Copy link
Member Author

jkrech commented Sep 19, 2025

@bgn42 can you please review and suggest how to fix the formatting.

jkrech and others added 4 commits September 19, 2025 15:07
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@qltysh
Copy link

qltysh bot commented Sep 19, 2025

Diff Coverage: The code coverage on the diff in this pull request is 0.0%.

Total Coverage: This PR will decrease coverage by 0.08%.

File Coverage Changes
Path File Coverage Δ Indirect
internal/stm32CubeMX/stm32CubeMX.go -0.2
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@github-actions
Copy link

Test Results

    6 files  ±0     54 suites  ±0   13s ⏱️ ±0s
  180 tests ±0    180 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 080 runs  ±0  1 080 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 80ed59b. ± Comparison against base commit 83cc362.

@jkrech jkrech requested a review from Copilot September 19, 2025 14:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@bgn42 bgn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment of Copilot seems to be good. At least a comment should be added to clarify that. It is no error only clarification.

@jkrech jkrech merged commit 28a0021 into main Sep 23, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: cbridge must strip pName from device when generating project.script file as CubeMX can only deal with devices

2 participants