Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes device name parsing for multi-core STM32 devices by stripping optional Pname components from the load command. The change addresses issue #226 by improving how device identifiers are processed when they contain vendor, Dname, and optional Pname components.
Key changes:
- Enhanced device string parsing to handle vendor::Dname:Pname format
- Strips optional Pname component to use only Dname for the load command
- Maintains backward compatibility for simpler device name formats
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@bgn42 can you please review and suggest how to fix the formatting. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Diff Coverage: The code coverage on the diff in this pull request is 0.0%. Total Coverage: This PR will decrease coverage by 0.08%. File Coverage Changes
🛟 Help
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bgn42
left a comment
There was a problem hiding this comment.
The comment of Copilot seems to be good. At least a comment should be added to clarify that. It is no error only clarification.
Fixes
project.scriptfile as CubeMX can only deal with devices #226Changes
strips optional Pname in case of multi-core device being selected.
Checklist