-
Notifications
You must be signed in to change notification settings - Fork 11
issue #455 fixed by checking for the file #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…f found, correct the path
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (2)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses issue #455 by fixing incorrect file path references in generated *.cgen.yml files for selected middleware. The changes implement a more robust file path resolution strategy that checks for files at multiple directory levels.
Key Changes:
- Enhanced file path resolution to check one directory level deeper when the initial path doesn't exist
- Adjusted the output path calculation to go up one directory level
- Updated STM32CubeMX.ioc file path to include the "STM32CubeMX" subdirectory
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/utils/utils.go | Added logic to check for files one level deeper in the directory structure and use that path if found |
| internal/readFile/readFile.go | Modified output path to go up one directory and corrected STM32CubeMX.ioc file path to include subdirectory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added unit test for that

... also one level deeper and if found, correct the path
Fixes
Changes
Checklist