Skip to content

Modeling - Update function handling in GeomFill_ConstrainedFilling and GeomFill_CoonsAlgPatch #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpasukhi wants to merge 1 commit into
base: IR
Choose a base branch
from
Open

Modeling - Update function handling in GeomFill_ConstrainedFilling and GeomFill_CoonsAlgPatch #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ModelingAlgorithms/TKGeomAlgo/GeomFill/GeomFill_ConstrainedFilling.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,9 +451,9 @@ void GeomFill_ConstrainedFilling::Init(const Handle(GeomFill_Boundary)& B1,
{
Handle(Law_Function) fu1, fu2;
ptch->Func(fu1, fu2);
fu1 = Law::MixBnd(Handle(Law_Linear)::DownCast(fu1));
fu2 = Law::MixBnd(Handle(Law_Linear)::DownCast(fu2));
ptch->Func(fu1, fu2);
Handle(Law_Function) ffu1 = Law::MixBnd(Handle(Law_Linear)::DownCast(fu1));
Handle(Law_Function) ffu2 = Law::MixBnd(Handle(Law_Linear)::DownCast(fu2));
ptch->SetFunc(ffu1, ffu2);
break;
}
}
Expand Down
5 changes: 2 additions & 3 deletions src/ModelingAlgorithms/TKGeomAlgo/GeomFill/GeomFill_CoonsAlgPatch.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,11 @@ void GeomFill_CoonsAlgPatch::Func(Handle(Law_Function)& f1, Handle(Law_Function)

//=================================================================================================

// gp_Pnt GeomFill_CoonsAlgPatch::Value(const Standard_Real U,
gp_Pnt GeomFill_CoonsAlgPatch::Value(const Standard_Real, const Standard_Real V) const
gp_Pnt GeomFill_CoonsAlgPatch::Value(const Standard_Real U, const Standard_Real V) const
{
Standard_Real a0, a1, a2, a3;
a0 = a[0]->Value(V);
a1 = a[1]->Value(V);
a1 = a[1]->Value(U);
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corrected parameter usage from V to U for a[1]->Value() represents a significant algorithmic change in the Coons patch evaluation. This change should be covered by a test case that verifies the correct blending behavior with different U and V parameters to ensure the patch is properly interpolated.

Copilot uses AI. Check for mistakes.
a2 = 1. - a0;
a3 = 1. - a1;
gp_XYZ cor, cortemp;
Expand Down
Loading