Visualization - Added visible flag to the layer settings. #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new flag controls if a layer is rendered or skipped.
dpasukhi
added
2. Enhancement
vttrtp
approved these changes
Dec 22, 2025
- Introduced a new test file for Graphic3d_ZLayerSettings, covering default constructor behavior, visibility toggling, and JSON dumping functionality. - Updated FILES.cmake to include the new test file.
There was a problem hiding this comment.
Pull request overview
This PR introduces a visibility flag to Graphic3d_ZLayerSettings that controls whether a layer is rendered or skipped during the rendering process. This feature enables selective layer rendering, which is particularly useful for advanced rendering scenarios like rendering specific layers to separate framebuffer objects (FBOs) for post-processing effects.
Key Changes:
- Added
myVisibleboolean field toGraphic3d_ZLayerSettingswith corresponding getter/setter methods - Modified the layer iterator in
OpenGl_LayerListto skip non-visible layers during rendering - Added comprehensive unit tests to validate the visibility flag behavior
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Visualization/TKService/Graphic3d/Graphic3d_ZLayerSettings.hxx |
Added visibility flag field, getter/setter methods, constructor initialization, and JSON dump support |
src/Visualization/TKService/GTests/Graphic3d_ZLayerSettings_Test.cxx |
New comprehensive test suite covering visibility flag behavior, default settings, and JSON serialization |
src/Visualization/TKService/GTests/FILES.cmake |
Registered the new test file in the build system |
src/Visualization/TKOpenGl/OpenGl/OpenGl_LayerList.cxx |
Updated layer iteration logic to skip non-visible layers during rendering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new flag controls if a layer is rendered or skipped.
Being able to toggle the visibility of a layer is helpful for some use cases. In my specific case, the flag is needed to render a layer with highlightings in a separate FBO for use in a post-processing effect. This flag is used to turn off the layer in normal rendering and turn it on for single-layer rendering in a different FBO.
CLA-ID: 951