add caching to _extract_spatial_extent_from_constraint_load_stac#1567
Closed
add caching to _extract_spatial_extent_from_constraint_load_stac#1567
Conversation
soxofaan
force-pushed
the
issue1565-extract-extent-from-constraints-with-caching
branch
from
78b9da6 to
f010650
Compare
Member
Author
|
probably not going to merge this. There is by now already caching in a couple of other places however, some parts of this PR are interesting to keep (e.g. added hashability of some objects), so I'm going to cherry pick those separately |
soxofaan
force-pushed
the
issue1565-extract-extent-from-constraints-with-caching
branch
from
f010650 to
f9f873d
Compare
…llection to allow caching
introduces caching on _extract_spatial_extent_from_load_stac_item_collection calls involves introducing new caching utilities (GetOrCallCacheInterface) and making some data structs cache key compatible (__hash__ + __eq__)
soxofaan
force-pushed
the
issue1565-extract-extent-from-constraints-with-caching
branch
from
f9f873d to
4485f55
Compare
Member
Author
|
the addition of feature flags with fe4f077 also make this place less ideal to add cache to, so closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #1565