Skip to content

feat: add process aggregate_spatial_window#575

Open
dsamaey wants to merge 5 commits intodevelopfrom
548-support-aggregate_spatial_window
Open

feat: add process aggregate_spatial_window#575
dsamaey wants to merge 5 commits intodevelopfrom
548-support-aggregate_spatial_window

Conversation

@dsamaey
Copy link
Contributor

@dsamaey dsamaey commented Nov 5, 2025

No description provided.

@dsamaey dsamaey linked an issue Nov 5, 2025 that may be closed by this pull request
@clausmichele
Copy link
Member

Are there news about this process? It would be important for the ClouDInSAR project.

@jdries @EmileSonneveld

@EmileSonneveld
Copy link
Member

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +641 to +646
val cols = originalCols / window._1
val rows = originalRows / window._2
val newLayout = LayoutDefinition(
RasterExtent(metadata.extent, CellSize(metadata.cellSize.width*window._1, metadata.cellSize.height*window._2)),
cols,
rows

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve full layout grid when coarsening tiles

runUserCodeSpatialWindowReduce builds the new LayoutDefinition with a RasterExtent whose column/row counts are just the coarsened tile dimensions, so LayoutDefinition computes layoutCols/layoutRows as 1×1 even when the input cube spans many tiles. The RDD keys are left unchanged, so the metadata no longer matches: downstream mapTransform/retiling/writing will treat every key as covering the full extent or mark keys as out of bounds. Any cube with more than one tile will therefore get incorrect spatial extents after a spatial window reduce.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support aggregate_spatial_window

3 participants