Tests for the test suite #468
Conversation
m-mohr
force-pushed
the
add-tests
branch
3 times, most recently
from
f7affe8 to
dafc6d9
Compare
m-mohr
force-pushed
the
add-tests
branch
3 times, most recently
from
7a70a55 to
0155298
Compare
m-mohr
force-pushed
the
add-tests
branch
10 times, most recently
from
51b2834 to
1982451
Compare
m-mohr
force-pushed
the
add-tests
branch
2 times, most recently
from
0e979e4 to
4069c31
Compare
|
I have the impression a lot of changes in the diff come from PR #490 |
Co-authored-by: Stefaan Lippens <soxofaan@users.noreply.github.com>
|
Thank you @soxofaan. I've rebased and the diff looks significantly cleaner now. |
soxofaan
left a comment
soxofaan
left a comment
There was a problem hiding this comment.
This PR is too large to give it a full in-depth review, but here are some random notes.
I guess it's more important to get this merged as "good enough" so that implementations can start integrate it, than to reach perfection.
| "arguments": { | ||
| "data": [] | ||
| }, | ||
| "returns": {"type": "nodata"} |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, but #550 has not been merged yet. We need to merge it first.
| "arguments": { | ||
| "data": [] | ||
| }, | ||
| "returns": {"type": "nodata"} |
There was a problem hiding this comment.
|
I merged in from draft, but the tests still need some updates to reflect the latest changes in there. Need to go through the changes and adapt the tests. And also add tests for text_find. |
Co-authored-by: Stefaan Lippens <soxofaan@users.noreply.github.com>
Co-authored-by: Stefaan Lippens <soxofaan@users.noreply.github.com>
github-project-automation
bot
moved this from In Progress
to Done
in Next processes release
See the README for details.
This PR includes the changes from PR #490.