Issue744 download optional #828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
reviewed
Nov 18, 2025
HansVRP
force-pushed
the
issue744_download_optional
branch
from
8c95197 to
5206a43
Compare
Contributor
Author
|
unclear why the unit tests are failing |
Member
|
failing tests are because of #829 but that is fixed now on master, so make sure to merge master in this feature branch |
HansVRP
force-pushed
the
issue744_download_optional
branch
from
5206a43 to
d90f06b
Compare
Contributor
Author
|
@soxofaan rebased |
soxofaan
added a commit
that referenced
this pull request
Nov 28, 2025
DummyBackend already covers all the mocking needs
soxofaan
added a commit
that referenced
this pull request
Nov 28, 2025
DummyBackend already covers all the mocking needs
soxofaan
force-pushed
the
issue744_download_optional
branch
from
a04316f to
d0bb37e
Compare
Member
|
finetuned the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.