Merged
Conversation
stefannikolei
force-pushed
the
sn/clang-tidy
branch
6 times, most recently
from
48a4941 to
6656b34
Compare
# Conflicts: # All.slnx
stefannikolei
force-pushed
the
sn/clang-tidy
branch
from
6656b34 to
37741d0
Compare
This should be stricter, explicitly only throwing relevant issues as warnings in projects that haven't fully replaced them yet (e.g. gotos).
We need to know its build settings, include dirs, etc. This can only be done from a build. As such, we'll let CMake handle generating the build database, and run after that. The MSVC generator does not support CMAKE_EXPORT_COMPILE_COMMANDS so we must use Ninja instead.
For this we need to setup the build environment.
Also ignore tests for now
It should be fine with it handling them through the source files directly. If not, it's better to move this to a dir-specific config file anyway, rather than here.
.cxx was to handle CMake's generated PCH files but it's not really needed. Our source files manually include the PCH header anyway, so all this seems to do is cause it to also match on CMake's output PCH files (.cxx.pch). Since it's pointless, we'll simplify it to the source file types we use.
twostars
force-pushed
the
sn/clang-tidy
branch
from
7bbd231 to
ec17b7b
Compare
Conflicts: .github/workflows/build_cmake_all.yml .github/workflows/build_msbuild_all.yml .github/workflows/build_msbuild_client.yml .github/workflows/build_msbuild_client_tools.yml .github/workflows/build_msbuild_server.yml .github/workflows/build_msbuild_tools.yml
twostars
force-pushed
the
sn/clang-tidy
branch
from
b6f205d to
46de48d
Compare
Generally I only want it to request changes, not approve. It shouldn't consider the PR "good to merge", just catch things that look wrong. But we'll see what this option looks like, since the comments are only visible on the files page as-is.
twostars
force-pushed
the
sn/clang-tidy
branch
2 times, most recently
from
7f7f1f3 to
fa3de5b
Compare
twostars
force-pushed
the
sn/clang-tidy
branch
from
fa3de5b to
80fe806
Compare
Also restore update behaviour for PR reviews (which don't work atm)
twostars
force-pushed
the
sn/clang-tidy
branch
6 times, most recently
from
cda0cdb to
3e24e4f
Compare
twostars
force-pushed
the
sn/clang-tidy
branch
from
3e24e4f to
c31e3c8
Compare
Permissions are too much of a hassle to deal with
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behaviour?
What is the new behaviour?
Why and how did I change this?
Was AI used at some point for any part of this change? If so, what?
Demo
Checklist