Skip to content

Green line under clan leaders name#825

Open
reignsprime wants to merge 4 commits intoOpen-KO:masterfrom
reignsprime:green-line
Open

Green line under clan leaders name#825
reignsprime wants to merge 4 commits intoOpen-KO:masterfrom
reignsprime:green-line

Conversation

@reignsprime
Copy link
Copy Markdown
Contributor

Draw the green line under the player name if they are a clan leader.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

What is the current behaviour?

No green line is drawn under the players name if they are a clan leader to address #374

What is the new behaviour?

The green line is drawn under the players name if they are a clan leader.

Why and how did I change this?

The packet was there to be read, however it was commented out in GameProcMain.
Move e_KnightsDuty up to InfoPlayerOther so it could be seen by all players to draw the green line for all clan leaders.
I think virtual is the cleanest way to do this but open to suggestions.

Was AI used at some point for any part of this change? If so, what?

No

Demo

image

Checklist

  • I have performed a self-review of my own code.
  • Where applicable, I have checked to make sure that this doesn't introduce incompatible behaviour with the official 1.298 server (e.g. unofficial opcodes or behavioural differences).
  • I have checked to make sure that this change does not already exist in the codebase in some fashion (e.g. UI already implemented under a different name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant