Green line under clan leaders name#825
Open
reignsprime wants to merge 4 commits intoOpen-KO:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draw the green line under the player name if they are a clan leader.
Pull request type
Please check the type of change your PR introduces:
What is the current behaviour?
No green line is drawn under the players name if they are a clan leader to address #374
What is the new behaviour?
The green line is drawn under the players name if they are a clan leader.
Why and how did I change this?
The packet was there to be read, however it was commented out in GameProcMain.
Move e_KnightsDuty up to InfoPlayerOther so it could be seen by all players to draw the green line for all clan leaders.
I think virtual is the cleanest way to do this but open to suggestions.
Was AI used at some point for any part of this change? If so, what?
No
Demo
Checklist