Skip to content

Conversation

@ReimarBauer
Copy link
Member

Purpose of PR?:

Fixes #2025

We can set the import filename for the name of the revisions.

use_importname_for_revision

@ReimarBauer
Copy link
Member Author

@matrss Do you know what the no-whitespace-issues wants to tell for this failure docs/development.rst:423: trailing whitespace.

Copy link
Contributor

@jgrooss jgrooss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the enhancement and it does seem to work as indicated by the video clip.

@matrss
Copy link
Collaborator

matrss commented Feb 17, 2025

@matrss Do you know what the no-whitespace-issues wants to tell for this failure docs/development.rst:423: trailing whitespace.

The CI action runs on a simulated merge of the PRs head branch into the base branch, not on the current commit of the head branch. At the time of the error the base branch was at 2b0eef4, which contains these errors. This is why they showed up here as well.

The errors on develop were then fixed in 905c54e, so any actions created afterwards should no longer exhibit the issue. But a simple rerun of the failed action run might not work out because it would reuse the old broken merge commit, instead of redoing it against the updated base branch. Updating the PRs head branch such that it gets a new commit sha (even without any changes) should have fixed that issue as well.

@ReimarBauer ReimarBauer merged commit a0c7ff4 into Open-MSS:develop Feb 17, 2025
7 of 11 checks passed
@ReimarBauer ReimarBauer deleted the i2025 branch February 17, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

on import to mscolab operations use filename as named revision

4 participants