timeout in fixture resolved #2929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If the server could not be started, shouldn't an error be raised instead? |
Member
Author
|
@joernu76 the server needs a bit time to startup. But I think raising an error now shows which tests get blocked by this. |
matrss
reviewed
Dec 8, 2025
matrss
reviewed
Dec 8, 2025
Co-authored-by: Matthias Riße <[email protected]>
matrss
approved these changes
Dec 8, 2025
annapurna-gupta
pushed a commit
to annapurna-gupta/MSS
that referenced
this pull request
Jan 2, 2026
--------- Co-authored-by: Matthias Riße <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #2928
Does this PR introduce a breaking change?
adds a timeout into a fixture for starting the eventlet_server
Checklist:
<type>: <subject>