Skip to content

Conversation

@ReimarBauer
Copy link
Member

@ReimarBauer ReimarBauer commented Dec 4, 2025

Purpose of PR?:

Fixes #2908 #2878

@ReimarBauer ReimarBauer changed the base branch from develop to stable December 4, 2025 13:04
@ReimarBauer ReimarBauer marked this pull request as draft December 4, 2025 17:49
@ReimarBauer ReimarBauer marked this pull request as ready for review December 4, 2025 19:23
pixi.toml Outdated
multidict = "*"
netcdf4 = "*"
numpy = ">=2"
numpy = ">=2.2.4,<3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numpy >=3 does not exist yet. Why do you presume it to be incompatible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was the suggestion here,
prefix-dev/pixi#3479

I read it all between 2.2.4 and lower 3 including 2.2.4
We need to start with 2.2.4 and not below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also wait until 3 exists, but yeah lower limit in our case would work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only need a minimum version, then there should only be a lower bound. Given that a version 3 does not exist I see no reason why we would assume that it won't work with MSS.

@ReimarBauer ReimarBauer requested a review from matrss December 5, 2025 20:25
@ReimarBauer ReimarBauer merged commit 9cdaa72 into Open-MSS:stable Dec 8, 2025
10 of 12 checks passed
@ReimarBauer ReimarBauer deleted the i2908 branch December 8, 2025 16:20
annapurna-gupta pushed a commit to annapurna-gupta/MSS that referenced this pull request Jan 2, 2026
annapurna-gupta pushed a commit to annapurna-gupta/MSS that referenced this pull request Jan 3, 2026
ReimarBauer added a commit that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS 13 runner image will be retired by December 4th, 2025.

3 participants