Updated Led Component to use no parameters, modified led_0 in pico2_overlay

Author: moisesmata

FprimeZephyrReference/Components/Led/Led.cpp

@@ -17,35 +17,13 @@ Led ::Led(const char* const compName) : LedComponentBase(compName) {}
 
 Led ::~Led() {}
 
-void Led ::parameterUpdated(FwPrmIdType id) {
-    Fw::ParamValid isValid = Fw::ParamValid::INVALID;
-    switch (id) {
-        case PARAMID_BLINK_INTERVAL: {
-            // Read back the parameter value
-            const U32 interval = this->paramGet_BLINK_INTERVAL(isValid);
-            // NOTE: isValid is always VALID in parameterUpdated as it was just properly set
-            FW_ASSERT(isValid == Fw::ParamValid::VALID, static_cast<FwAssertArgType>(isValid));
-
-            // Emit the blink interval set event
-            this->log_ACTIVITY_HI_BlinkIntervalSet(interval);
-            break;
-        }
-        default:
-            FW_ASSERT(0, static_cast<FwAssertArgType>(id));
-            break;
-    }
-}
-
 // ----------------------------------------------------------------------
 // Handler implementations for user-defined typed input ports
 // ----------------------------------------------------------------------
 
 void Led ::run_handler(FwIndexType portNum, U32 context) {
-    // Read back the parameter value
-    Fw::ParamValid isValid = Fw::ParamValid::INVALID;
-    U32 interval = this->paramGet_BLINK_INTERVAL(isValid);
-    FW_ASSERT((isValid != Fw::ParamValid::INVALID) && (isValid != Fw::ParamValid::UNINIT),
-              static_cast<FwAssertArgType>(isValid));
+
+    U32 interval = this->m_blinkInterval; // Get the blink interval from the member variable
 
     // Only perform actions when set to blinking
     if (this->m_blinking && (interval != 0)) {
@@ -96,4 +74,15 @@ void Led ::BLINKING_ON_OFF_cmdHandler(FwOpcodeType opCode, U32 cmdSeq, Fw::On on
     this->cmdResponse_out(opCode, cmdSeq, Fw::CmdResponse::OK);
 }
 
+void Led ::SET_BLINK_INTERVAL_cmdHandler(FwOpcodeType opCode, U32 cmdSeq, U32 interval) {
+    // Update the member variable
+    this->m_blinkInterval = interval;
+    
+    // Log the event
+    this->log_ACTIVITY_HI_BlinkIntervalSet(interval);
+    
+    // Provide command response
+    this->cmdResponse_out(opCode, cmdSeq, Fw::CmdResponse::OK);
+}
+
 }  // namespace Components

FprimeZephyrReference/Components/Led/Led.fpp

@@ -7,6 +7,11 @@ module Components {
                 onOff: Fw.On @< Indicates whether the blinking should be on or off
         )
 
+        @ Command to set the LED blink interval
+        async command SET_BLINK_INTERVAL(
+                interval: U32 @< Blink interval in rate group ticks
+        )
+
         @ Telemetry channel to report blinking state.
         telemetry BlinkingState: Fw.On
 
@@ -28,9 +33,6 @@ module Components {
             severity activity high \
             format "LED blink interval set to {}"
 
-        @ Blinking interval in rate group ticks
-        param BLINK_INTERVAL: U32 default 1
-
         @ Port receiving calls from the rate group
         async input port run: Svc.Sched
 
@@ -61,11 +63,5 @@ module Components {
         @ Port for sending telemetry channels to downlink
         telemetry port tlmOut
 
-        @ Port to return the value of a parameter
-        param get port prmGetOut
-
-        @Port to set the value of a parameter
-        param set port prmSetOut
-
     }
 }

FprimeZephyrReference/Components/Led/Led.hpp

@@ -24,13 +24,6 @@ class Led : public LedComponentBase {
     //! Destroy Led object
     ~Led();
 
-    private :
-        //! Emit parameter updated EVR
-        //!
-        void
-        parameterUpdated(FwPrmIdType id  //!< The parameter ID
-                         ) override;
-
     private :
 
         // ----------------------------------------------------------------------
@@ -58,13 +51,23 @@ class Led : public LedComponentBase {
                                    U32 cmdSeq,           //!< The command sequence number
                                    Fw::On onOff          //!< Indicates whether the blinking should be on or off
                                    ) override;
+         
+        //! Handler implementation for command SET_BLINK_INTERVAL
+        //!
+        //! Command to set the LED blink interval
+        void
+        SET_BLINK_INTERVAL_cmdHandler(FwOpcodeType opCode,  //!< The opcode
+                                      U32 cmdSeq,           //!< The command sequence number
+                                      U32 interval          //!< Blink interval in rate group ticks
+                                      ) override;
 
     Fw::On m_state = Fw::On::OFF;  //! Keeps track if LED is on or off
     U64 m_transitions = 0;         //! The number of on/off transitions that have occurred
                                    //! from FSW boot up
     U32 m_toggleCounter = 0;       //! Keeps track of how many ticks the LED has been on for
     bool m_blinking = false;       //! Flag: if true then LED blinking will occur else
                                    //! no blinking will happen
+    U32 m_blinkInterval = 10;      //! Blink interval in rate group ticks (FIX FOR ZEPHYR)
 };
 
 }  // namespace Components

boards/proves_fc_v5c.overlay

@@ -9,3 +9,9 @@
         zephyr,console = &cdc_acm_uart0;
     };
 };
+
+/* Override the default LED definition to use GPIO 24 instead of GPIO 25 for PROVES FC board*/
+&led0 {
+    gpios = <&gpio0 24 GPIO_ACTIVE_HIGH>;
+    label = "User LED GPIO24";
+};