Skip to content

Conversation

@ineskhou
Copy link
Contributor

@ineskhou ineskhou commented Sep 10, 2025

Summary

This pull request introduces a new AntennaDeployer component to the system, enabling automated antenna deployment with burnwire activation and distance sensor feedback. The implementation includes the component code, interface definition, documentation, build integration, and system wiring. The most important changes are grouped below:

Component Implementation & Interface

  • Added new files: AntennaDeployer.cpp, AntennaDeployer.hpp, and AntennaDeployer.fpp, implementing the deployment logic, command handlers, state machine, distance validation, and F Prime interface for the antenna deployment process. [1] [2] [3]

System Integration

  • Registered the AntennaDeployer as part of the build by updating Components/CMakeLists.txt and adding its own CMake configuration. [1] [2]
  • Added a new instance of AntennaDeployer to the deployment topology and instance files, and connected its ports to the rate group and burnwire component. [1] [2] [3] [4]

Telemetry & Monitoring

  • Defined a new telemetry packet for antenna deployment status, including DeployCount and LastDistance channels.

Documentation

  • Added a new system design document (docs/sdd.md) detailing requirements, usage, states, commands, events, telemetry, and parameters for the AntennaDeployer component.

Minor Updates

  • Minor formatting and whitespace changes in instances.fpp.

This Summary was written by Copilot AI

@ineskhou ineskhou moved this to In progress in v0.1-v0.3 Sep 10, 2025
@ineskhou ineskhou moved this from In progress to V0.1 | Minimum Viable Satellite in v0.1-v0.3 Sep 18, 2025
@ineskhou ineskhou self-assigned this Sep 30, 2025
@ineskhou ineskhou removed their assignment Oct 19, 2025
@ineskhou
Copy link
Contributor Author

@yudataguy I did the merge so it should be up to date with main! Right now there is an sdd you probably want to review adn start on the fpp. lmk if you have any questions

@yudataguy
Copy link
Collaborator

@ineskhou can i bump the MAX_PACKETIZER_PACKETS to 8? Since it was set to 6, and with antenna packet, it exceeds the limit

@yudataguy yudataguy requested review from LeStarch and removed request for LeStarch October 22, 2025 04:31
@yudataguy yudataguy marked this pull request as ready for review October 22, 2025 04:31
@ineskhou
Copy link
Contributor Author

@yudataguy Yes, increasing the packet size to 8 is perfect, you'll be changing things in the config all the time!

@ineskhou ineskhou moved this from V0.1 | Minimum Viable Satellite to In progress in v0.1-v0.3 Oct 22, 2025
@ineskhou ineskhou moved this from In progress to In review in v0.1-v0.3 Oct 23, 2025
@ineskhou
Copy link
Contributor Author

image

works great on Hardware!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an Antenna Deployer component that automates antenna deployment via a burnwire mechanism. The deployer manages the deployment lifecycle through a state machine, monitors distance sensor feedback to confirm deployment, and supports retry logic with configurable timing parameters.

  • Introduces AntennaDeployer component with commands, telemetry, events, and timing parameters
  • Integrates the new component into the ReferenceDeployment topology
  • Adds integration tests with reduced timing constants for faster test execution

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
FprimeZephyrReference/test/int/burnwire_test.py Increased timeout for burnwire state assertion from 10 to 15 seconds
FprimeZephyrReference/test/int/antenna_deployer_test.py New integration test suite verifying deployment without distance sensor feedback
FprimeZephyrReference/project/config/TlmPacketizerCfg.hpp Increased max packetizer packets from 7 to 8 to accommodate new telemetry
FprimeZephyrReference/ReferenceDeployment/Top/topology.fpp Added antennaDeployer instance to topology with connections to rate group and burnwire
FprimeZephyrReference/ReferenceDeployment/Top/instances.fpp Declared antennaDeployer instance with base ID 0x10029000
FprimeZephyrReference/ReferenceDeployment/Top/ReferenceDeploymentPackets.fppi Added Antenna packet definition with deployment telemetry
FprimeZephyrReference/Components/CMakeLists.txt Added AntennaDeployer subdirectory to build system
FprimeZephyrReference/Components/AntennaDeployer/docs/sdd.md Added software design document with requirements, usage, and API documentation
FprimeZephyrReference/Components/AntennaDeployer/CMakeLists.txt CMake configuration for AntennaDeployer component library
FprimeZephyrReference/Components/AntennaDeployer/AntennaDeployer.hpp Header file defining component class with state machine and helper methods
FprimeZephyrReference/Components/AntennaDeployer/AntennaDeployer.fpp FPP specification defining commands, events, telemetry, ports, and parameters
FprimeZephyrReference/Components/AntennaDeployer/AntennaDeployer.cpp Implementation of deployment state machine and command handlers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor Author

@ineskhou ineskhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some tests and sdd updates! sorry for al the pushed the local tests dont work on my computer

Copy link
Contributor

@Mikefly123 Mikefly123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ineskhou just a small tweak, I think we should change the naming of the DeployCount telemetry to be more clear.

I can stick copilot on making this change if that is alright with you.

# Telemetry
######################################################################
@ Counts the number of deployment attempts across boots
telemetry DeployCount: U32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should tweak the name for this to make it more clear what this piece of telemetry is:

Suggested change
telemetry DeployCount: U32
telemetry DeployAttemptCount: U32

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a plan!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you address the change requested in this review? Modify all of the DeployCount names to be DeployAttemptCount instead!

@Mikefly123 Mikefly123 self-requested a review October 24, 2025 20:15
@Mikefly123 Mikefly123 changed the title Antenna deployer Antenna Deployer Oct 24, 2025
Copy link
Contributor

@Mikefly123 Mikefly123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the hard work on this @ineskhou and @yudataguy

@Mikefly123 Mikefly123 merged commit cfac1aa into main Oct 24, 2025
3 checks passed
@Mikefly123 Mikefly123 deleted the antenna_deployer branch October 24, 2025 23:56
@github-project-automation github-project-automation bot moved this from In review to Done in v0.1-v0.3 Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants