-
Notifications
You must be signed in to change notification settings - Fork 6
Antenna Deployer #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Antenna Deployer #14
Conversation
|
@yudataguy I did the merge so it should be up to date with main! Right now there is an sdd you probably want to review adn start on the fpp. lmk if you have any questions |
|
@ineskhou can i bump the |
|
@yudataguy Yes, increasing the packet size to 8 is perfect, you'll be changing things in the config all the time! |
…-core-reference into antenna_deployer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an Antenna Deployer component that automates antenna deployment via a burnwire mechanism. The deployer manages the deployment lifecycle through a state machine, monitors distance sensor feedback to confirm deployment, and supports retry logic with configurable timing parameters.
- Introduces
AntennaDeployercomponent with commands, telemetry, events, and timing parameters - Integrates the new component into the ReferenceDeployment topology
- Adds integration tests with reduced timing constants for faster test execution
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| FprimeZephyrReference/test/int/burnwire_test.py | Increased timeout for burnwire state assertion from 10 to 15 seconds |
| FprimeZephyrReference/test/int/antenna_deployer_test.py | New integration test suite verifying deployment without distance sensor feedback |
| FprimeZephyrReference/project/config/TlmPacketizerCfg.hpp | Increased max packetizer packets from 7 to 8 to accommodate new telemetry |
| FprimeZephyrReference/ReferenceDeployment/Top/topology.fpp | Added antennaDeployer instance to topology with connections to rate group and burnwire |
| FprimeZephyrReference/ReferenceDeployment/Top/instances.fpp | Declared antennaDeployer instance with base ID 0x10029000 |
| FprimeZephyrReference/ReferenceDeployment/Top/ReferenceDeploymentPackets.fppi | Added Antenna packet definition with deployment telemetry |
| FprimeZephyrReference/Components/CMakeLists.txt | Added AntennaDeployer subdirectory to build system |
| FprimeZephyrReference/Components/AntennaDeployer/docs/sdd.md | Added software design document with requirements, usage, and API documentation |
| FprimeZephyrReference/Components/AntennaDeployer/CMakeLists.txt | CMake configuration for AntennaDeployer component library |
| FprimeZephyrReference/Components/AntennaDeployer/AntennaDeployer.hpp | Header file defining component class with state machine and helper methods |
| FprimeZephyrReference/Components/AntennaDeployer/AntennaDeployer.fpp | FPP specification defining commands, events, telemetry, ports, and parameters |
| FprimeZephyrReference/Components/AntennaDeployer/AntennaDeployer.cpp | Implementation of deployment state machine and command handlers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Mostly spelling corrections! Co-authored-by: Copilot <[email protected]>
…ation/proves-core-reference into antenna_deployer
ineskhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some tests and sdd updates! sorry for al the pushed the local tests dont work on my computer
Mikefly123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ineskhou just a small tweak, I think we should change the naming of the DeployCount telemetry to be more clear.
I can stick copilot on making this change if that is alright with you.
| # Telemetry | ||
| ###################################################################### | ||
| @ Counts the number of deployment attempts across boots | ||
| telemetry DeployCount: U32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should tweak the name for this to make it more clear what this piece of telemetry is:
| telemetry DeployCount: U32 | |
| telemetry DeployAttemptCount: U32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like a plan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot can you address the change requested in this review? Modify all of the DeployCount names to be DeployAttemptCount instead!
Mikefly123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the hard work on this @ineskhou and @yudataguy

Summary
This pull request introduces a new
AntennaDeployercomponent to the system, enabling automated antenna deployment with burnwire activation and distance sensor feedback. The implementation includes the component code, interface definition, documentation, build integration, and system wiring. The most important changes are grouped below:Component Implementation & Interface
AntennaDeployer.cpp,AntennaDeployer.hpp, andAntennaDeployer.fpp, implementing the deployment logic, command handlers, state machine, distance validation, and F Prime interface for the antenna deployment process. [1] [2] [3]System Integration
AntennaDeployeras part of the build by updatingComponents/CMakeLists.txtand adding its own CMake configuration. [1] [2]AntennaDeployerto the deployment topology and instance files, and connected its ports to the rate group andburnwirecomponent. [1] [2] [3] [4]Telemetry & Monitoring
DeployCountandLastDistancechannels.Documentation
docs/sdd.md) detailing requirements, usage, states, commands, events, telemetry, and parameters for theAntennaDeployercomponent.Minor Updates
instances.fpp.This Summary was written by Copilot AI