Load Switch: Add State Get Port, Remove Reset Port #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateinaction
commented
Nov 30, 2025
| k_sleep(K_MSEC(100)); | ||
| this->setLoadSwitchState(Fw::On::ON); | ||
| Fw::On LoadSwitch ::loadSwitchStateGet_handler(FwIndexType portNum) { | ||
| return this->getLoadSwitchState() && this->getTime() > this->m_on_timeout ? Fw::On::ON : Fw::On::OFF; |
Collaborator
Author
There was a problem hiding this comment.
This is kind of funny and, at a minimum, need to be marked in the SDD. The state will only report as ON after some delay m_on_timeout which is currently hardcoded to 1s. This allows us to replicate the behavior from Michael's TCA_Up branch which waited 200ms "for power to stabilize" after turning the load switch on. We needed this to reliably enable devices on the load switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a port to the load switch to get the state to of the port. The PR also removes the reset port as requested during the software review on Nov 30.
Related Issues/Tickets
How Has This Been Tested?
Manually tested state get port in thermal manager changes. The thermal manager only tries to read the temp sensor if the load switch is turned on.
Screenshots / Recordings (if applicable)
Checklist
Further Notes / Considerations