add agi designers list#11
Open
vince19972 wants to merge 1 commit intoOpen-Source-Studio-at-ITP:masterfrom
vince19972:master
Open
add agi designers list#11vince19972 wants to merge 1 commit intoOpen-Source-Studio-at-ITP:masterfrom vince19972:master
vince19972 wants to merge 1 commit intoOpen-Source-Studio-at-ITP:masterfrom
vince19972:master
Conversation
shiffman
requested changes
Sep 25, 2018
Member
shiffman
left a comment
shiffman
left a comment
There was a problem hiding this comment.
Nice job! Some small suggestions / fixes!
| @@ -0,0 +1,715 @@ | |||
| [ | |||
Member
There was a problem hiding this comment.
I believe the standard format for corpora is to start with an object and then include the list as a named array. The objects generally also include "description" and "source" properties:
{
"description": "____________",
"source": "____________",
"designers": [ ]
}
| "Martin Venezky", | ||
| "Martin Woodtli", | ||
| "Martti Mykk\u00e4nen", | ||
| "Masaaki Hiromura" |
Member
Author
There was a problem hiding this comment.
!! Sorry I didn't check it carefully and even not aware of the result from CI testings 😭
hugovk
reviewed
Sep 25, 2018
| "Yung-Chen Nieh", | ||
| "Adrian Frutiger", | ||
| "Adrian Shaughnessy", | ||
| "Aimo Katajam\u00e4ki", |
There was a problem hiding this comment.
If the file is UTF-8 encoded, this could be "Aimo Katajamäki" rather than escaping characters. (Same below for others with \uXXXX values.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.