Skip to content

Fixes #2580 export of comparison results fails#2581

Merged
rwmcintosh merged 1 commit intodevelopfrom
2580-export-of-comparison-results-fails
Aug 7, 2025
Merged

Fixes #2580 export of comparison results fails#2581
rwmcintosh merged 1 commit intodevelopfrom
2580-export-of-comparison-results-fails

Conversation

@rwmcintosh
Copy link
Member

Fixes #2580

Description

Comparison table should indicate the module when comparing building blocks. Otherwise it's confusing which is which. This cascades into a problem when exporting because the view can handle columns with the same name, but the datatable used for export to excel cannot.

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

module name added for module building blocks

image

Questions (if appropriate):

@rwmcintosh rwmcintosh self-assigned this Aug 7, 2025
@rwmcintosh rwmcintosh added this to v12.1 Aug 7, 2025
Comment on lines +22 to +25
public static IMenuBarButton CompareBuildingBlocksMenu(IReadOnlyList<IBuildingBlock> buildingBlocksToCompare, IOSPSuiteExecutionContext context, IContainer container)
{
return CompareObjectsMenu(buildingBlocksToCompare, buildingBlocksToCompare.Select(x => x.DisplayName).ToList(), context, container);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying hard to understand how this change fixes the Excel export...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The secret is that the left/right caption in the view has changed to include the module name. When exporting, the datatable is created with the view left/right caption. They have to be unique.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it all comes from the context menu creation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting...

@rwmcintosh rwmcintosh merged commit 2bcadc6 into develop Aug 7, 2025
1 check passed
@rwmcintosh rwmcintosh deleted the 2580-export-of-comparison-results-fails branch August 7, 2025 15:21
@github-project-automation github-project-automation bot moved this to Done in v12.1 Aug 7, 2025
@Yuri05 Yuri05 moved this from Done to Verified in v12.1 Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Verified

Development

Successfully merging this pull request may close these issues.

export of comparison results fails

2 participants