Fixes #2580 export of comparison results fails#2581
Merged
rwmcintosh merged 1 commit intodevelopfrom Aug 7, 2025
Merged
Conversation
Yuri05
reviewed
Aug 7, 2025
Comment on lines
+22
to
+25
| public static IMenuBarButton CompareBuildingBlocksMenu(IReadOnlyList<IBuildingBlock> buildingBlocksToCompare, IOSPSuiteExecutionContext context, IContainer container) | ||
| { | ||
| return CompareObjectsMenu(buildingBlocksToCompare, buildingBlocksToCompare.Select(x => x.DisplayName).ToList(), context, container); | ||
| } |
Member
There was a problem hiding this comment.
trying hard to understand how this change fixes the Excel export...
Member
Author
There was a problem hiding this comment.
The secret is that the left/right caption in the view has changed to include the module name. When exporting, the datatable is created with the view left/right caption. They have to be unique.
Member
Author
There was a problem hiding this comment.
it all comes from the context menu creation.
Yuri05
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2580
Description
Comparison table should indicate the module when comparing building blocks. Otherwise it's confusing which is which. This cascades into a problem when exporting because the view can handle columns with the same name, but the datatable used for export to excel cannot.
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
module name added for module building blocks
Questions (if appropriate):