Skip to content

Fixes #2599 Extend PV BB with expression profiles - wrong formula expression in plasma#2600

Merged
rwmcintosh merged 1 commit intodevelopfrom
1998-extend-pv-bb-with-expression-profiles---wrong-formula-for-expression-in-plasma
Aug 25, 2025
Merged

Fixes #2599 Extend PV BB with expression profiles - wrong formula expression in plasma#2600
rwmcintosh merged 1 commit intodevelopfrom
1998-extend-pv-bb-with-expression-profiles---wrong-formula-for-expression-in-plasma

Conversation

@rwmcintosh
Copy link
Member

Fixes #2599

Description

Let's select the most frequently occurring formula for the nex ParameterValue from the matching ExpressionParameters.
Including values, so if there's a formula or value that occurs more than others, we will use that.

This is when we extend a ParameterValueBB to include expression parameters for a container and molecule.

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

@rwmcintosh rwmcintosh merged commit 335920f into develop Aug 25, 2025
1 check passed
@rwmcintosh rwmcintosh deleted the 1998-extend-pv-bb-with-expression-profiles---wrong-formula-for-expression-in-plasma branch August 25, 2025 10:11
@github-project-automation github-project-automation bot moved this to Done in v12.1 Aug 25, 2025
@Yuri05 Yuri05 moved this from Done to Verified in v12.1 Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Verified

Development

Successfully merging this pull request may close these issues.

Extend PV BB with expression profiles - wrong formula for expression in plasma

2 participants