Fixes #2601 Error when selecting "Link Data To Simulations"

[rwmcintosh]

Fixes #2601

Description

Some order and selection issues when we are trying to update Used state for a linked observation column as we select/deselect the matching calculation column.

Type of change

Please mark relevant options with an x in the brackets.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires documentation changes (link at least one user or developer documentation issue):
• Algorithm update - updates algorithm documentation/questions/answers etc.
• Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Integration tests
• Unit tests
• Manual tests
• No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

• Check if the code is well documented
• Check if the behavior is what is expected
• Check if the code is well tested
• Check if the code is readable and well formatted
• Additional checks (document below if any)
• Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

[rwmcintosh]

I removed this option because I think we want the group rows to function as a multi select. In other words, if I select the 'Simulation' group and then I set the Used checkbox, all simulation outputs should be added. Selecting the group is the same as selecting all the rows of the group.

[msevestre]

what if you have multiple grouping? Does that work?

[rwmcintosh]

yep. Group rows have negative row indexes. The extension method takes care of it all.

[rwmcintosh]

@benjaperez1983 can you revert the changes you pushed to this branch and create a new PR for the color changes

[msevestre]

Unclear to me where the code fixes the issusue 2601. There is lots of noise around setting colors etc but the actual "Sequence" not found is not seen at first glance
Naming is hard..isLinkedDataToSimulation remains a mystery.
Does it mean that oberved data is llink to simuatlion results?

[rwmcintosh]

Unclear to me where the code fixes the issusue 2601. There is lots of noise around setting colors etc but the actual "Sequence" not found is not seen at first glance
Naming is hard..isLinkedDataToSimulation remains a mystery.
Does it mean that oberved data is llink to simuatlion results?

I asked Ben to reverse his color changes from this pr

[rwmcintosh]

I think the color matching should go into v13 rather than 12.1. Difference is that's a new feature where this original report is a crash fix.