Merged
Conversation
msevestre
reviewed
Aug 27, 2025
msevestre
reviewed
Aug 27, 2025
msevestre
reviewed
Aug 27, 2025
Member
msevestre
left a comment
msevestre
left a comment
There was a problem hiding this comment.
wondering about true vs false
Member
|
it is not ignored. It is used to know whether to mark the changes as needing to be saved or not |
Member
Author
|
isn't that what we want then? True to signal that the project should be saved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2607
Description
We need a consistent chain of project converters where there's always a converter for a new PKML version. In this case, no active conversion is necessary since the pkml is forward compatible, but not backward compatible.