Fixes #2739 PI options not visible on small screens

[rwmcintosh]

Fixes #2739 PI options not visible on small screens

Description

Calculate and apply a min height for the control. The scrollbar would not be displayed until this was done

Type of change

Please mark relevant options with an x in the brackets.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires documentation changes (link at least one user or developer documentation issue):
• Algorithm update - updates algorithm documentation/questions/answers etc.
• Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Integration tests
• Unit tests
• Manual tests
• No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

• Check if the code is well documented
• Check if the behavior is what is expected
• Check if the code is well tested
• Check if the code is readable and well formatted
• Additional checks (document below if any)
• Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

[rwmcintosh]

Before

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed scrollbar visibility issue for Parameter Identification options on small screens by calculating and applying a minimum height to the pivot grid control.

• Added OptimalHeight property to UxPivotGrid that calculates the minimum height needed by summing header areas and accounting for horizontal scrollbar
• Applied the calculated minimum height when binding data to ensure scrollbar displays correctly
• Includes minor formatting improvements (spacing around braces) for consistency with codebase style
• The fix ensures the control's minimum size is set only when the layout item is visible

Confidence Score: 5/5

• This PR is safe to merge - it's a focused bug fix with clear logic and no risk of side effects
• The change is minimal, well-targeted, and solves a specific UI issue. The OptimalHeight calculation uses standard DevExpress API methods, and the minimum size is only applied when the control is visible. The fix has been manually tested per the PR description.
• No files require special attention

Important Files Changed

Filename	Overview
src/OSPSuite.UI/Controls/UxPivotGrid.cs	Added OptimalHeight property to calculate minimum height for pivot grid display, plus minor formatting cleanup for spacing consistency
src/OSPSuite.UI/Views/ParameterIdentifications/CategorialParameterIdentificationRunModeView.cs	Sets MinimumSize using OptimalHeight to ensure scrollbar visibility when control is shown

Sequence Diagram

sequenceDiagram
    participant View as CategorialParameterIdentificationRunModeView
    participant Control as UxPivotGrid
    participant ViewInfo as PivotGridViewInfo
    
    Note over View: BindTo(categorialRunModeDTO)
    View->>View: Check if layoutItemPivotGrid.Visibility != Never
    alt Control is visible
        View->>Control: Get OptimalHeight
        Control->>Control: EnsureViewInfoIsCalculated()
        Control->>ViewInfo: Get Data.ViewInfo
        ViewInfo-->>Control: Return ViewInfo
        Control->>ViewInfo: Get RowAreaFields.Bounds.Height
        Control->>ViewInfo: Get FilterHeaders.Bounds.Height
        Control->>ViewInfo: Get RowHeaders.Bounds.Height
        Control->>ViewInfo: Get DataHeaders.Bounds.Height
        Control->>ViewInfo: Check IsHScrollBarVisible
        alt Horizontal scrollbar is visible
            Control->>ViewInfo: Add ScrollBarSize.Height
        end
        Control-->>View: Return calculated height
        View->>Control: Set MinimumSize with OptimalHeight
        Note over Control: Scrollbar now displays correctly
    end

Loading

[greptile-apps]

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}