Fix TableFormula error message to show existing Y value#2778
Merged
Fix TableFormula error message to show existing Y value#2778
Conversation
Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com>
Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix misleading error message for existing x-value in TableFormula
Fix TableFormula error message to show existing Y value
Feb 24, 2026
rwmcintosh
requested changes
Feb 24, 2026
| return index; | ||
|
|
||
| throw new ValuePointAlreadyExistsForPointException(point); | ||
| throw new ValuePointAlreadyExistsForPointException(point.X, existingPoint.Y); |
Member
There was a problem hiding this comment.
@copilot just call the existing constructor with existingPoint. Remove the additional constructor that was added.
Contributor
Author
There was a problem hiding this comment.
Done in commit 2d5ce04. Removed the new constructor overload and now calling the existing constructor with existingPoint instead.
…rload Co-authored-by: rwmcintosh <261477+rwmcintosh@users.noreply.github.com>
rwmcintosh
approved these changes
Feb 24, 2026
Yuri05
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding a point with a duplicate X coordinate but different Y value,
TableFormula.AddPointshowed the attempted Y value in the error message instead of the existing Y value.Example:
Changes:
TableFormula.cs: PassexistingPointinstead ofpointto the existing exception constructorTableFormulaSpecs.cs: Add test verifying error message contains existing Y valueOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.