Conversation
Member
Author
|
Let's also target .NET 8 explicitly. That will require upgrading all the assemblies in MoBi (already done) and PK-Sim. This is only going to happen on the v13 branches. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with System.Text.Json compatibility in atypical assembly loading scenarios by downgrading the package version and updating the target framework. The changes ensure the library works correctly with rSharp when loading .NET assemblies from R without requiring a deps.json file.
- Downgraded System.Text.Json from version 9.0.8 to 8.0.6
- Changed target framework from netstandard2.0 to net8
- Added package read permissions to the build workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/OSPSuite.Utility/OSPSuite.Utility.csproj | Updated target framework to net8 and downgraded System.Text.Json to version 8.0.6 |
| .github/workflows/build-pr.yml | Added packages read permission to support the build workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Yuri05
reviewed
Oct 23, 2025
Yuri05
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
Fixes #41
If we use the latest version of System.Text.JSON then we have to provide a
MyPackage.deps.jsonfile when using it with .NET 8.Since we use this atypical load scenario with rSharp to support running our .NET code from R we cannot rely on a
deps.jsonfile being available during assembly load and so we have to use the version that ships with the target framework.