Skip to content

V3-1799 UpdateParameterIdentification Using#3084

Merged
rwmcintosh merged 8 commits intodevelopfrom
V3-1799-Pending-Issues-when-12.1-Core-merges-into-develop-branch
Mar 11, 2025
Merged

V3-1799 UpdateParameterIdentification Using#3084
rwmcintosh merged 8 commits intodevelopfrom
V3-1799-Pending-Issues-when-12.1-Core-merges-into-develop-branch

Conversation

@benjaperez1983
Copy link
Contributor

@benjaperez1983 benjaperez1983 commented Feb 26, 2025

Fixes #3086

Description

Whe using the funtion to "Reload under the same settings", and the updated data set has less values that the previous one and it was used in a PI

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests -> on Core
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

@benjaperez1983 benjaperez1983 self-assigned this Feb 26, 2025
Copy link
Member

@rwmcintosh rwmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this parameter type change and link the PR to an issue in PK-Sim.
I also know this is related to a change in OSPSuite.Core, so link that in the comments as well to give context to the next reviewer.

@benjaperez1983
Copy link
Contributor Author

This Issue is related to> Open-Systems-Pharmacology/OSPSuite.Core#2179

@rwmcintosh
Copy link
Member

Is there an issue # in PK-Sim for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update to the latest version of the templates module, otherwsie it would be downgraded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuri05 Would you help me out here?
I just ran git checkout develop over the 3 files but I get no changes at all.
In fact not sure how this changes made it here. What are this templates exaclty and how to update them?

Copy link
Member

@Yuri05 Yuri05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwmcintosh rwmcintosh requested a review from Yuri05 March 4, 2025 16:26
Copy link
Member

@Yuri05 Yuri05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

templates submodule still downgraded

@rwmcintosh rwmcintosh requested a review from Yuri05 March 10, 2025 12:13
@rwmcintosh rwmcintosh merged commit f7cf715 into develop Mar 11, 2025
1 check passed
@rwmcintosh rwmcintosh deleted the V3-1799-Pending-Issues-when-12.1-Core-merges-into-develop-branch branch March 11, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importer: "Reload under the same settings" does not work

3 participants