Fixes #2979 Update 3rd party components to latest#3085
Merged
rwmcintosh merged 5 commits intodevelopfrom Mar 4, 2025
Merged
Conversation
rwmcintosh
commented
Mar 3, 2025
Comment on lines
+28
to
+29
| if (concreteType.GetCustomAttribute<System.Runtime.CompilerServices.CompilerGeneratedAttribute>() != null) | ||
| return; |
Member
Author
There was a problem hiding this comment.
Not sure how this broke, but I found that some compiler generated classes were registered more than once breaking this scanning convention.
Member
Author
There was a problem hiding this comment.
There is a transitive update to Castle Core involved here.
Yuri05
reviewed
Mar 3, 2025
src/PKSim.Assets/PKSim.Assets.csproj
Outdated
| <OutputPath>bin\$(Configuration)</OutputPath> | ||
| <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile> | ||
| <NoWarn>1591</NoWarn> | ||
| <Version Condition="'$(Version)' == ''">12.1.0.0</Version> |
Member
Author
Member
Author
Yuri05
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #2979
Description
Updates and code changes to accommodate
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
Questions (if appropriate):