Skip to content

Fixes #2979 Update 3rd party components to latest#3085

Merged
rwmcintosh merged 5 commits intodevelopfrom
2979-update-3rd-party-components-to-latest
Mar 4, 2025
Merged

Fixes #2979 Update 3rd party components to latest#3085
rwmcintosh merged 5 commits intodevelopfrom
2979-update-3rd-party-components-to-latest

Conversation

@rwmcintosh
Copy link
Member

Fixes #2979

Description

Updates and code changes to accommodate

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

@rwmcintosh rwmcintosh self-assigned this Mar 3, 2025
@rwmcintosh rwmcintosh added this to v12.1 Mar 3, 2025
Comment on lines +28 to +29
if (concreteType.GetCustomAttribute<System.Runtime.CompilerServices.CompilerGeneratedAttribute>() != null)
return;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this broke, but I found that some compiler generated classes were registered more than once breaking this scanning convention.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a transitive update to Castle Core involved here.

<OutputPath>bin\$(Configuration)</OutputPath>
<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
<NoWarn>1591</NoWarn>
<Version Condition="'$(Version)' == ''">12.1.0.0</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12.1.0.0 or 12.1.0 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you define all 3 digits. That's what we had for local builds of 11.3 -> 11.3.0.0
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
That's where it makes a difference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom

@rwmcintosh rwmcintosh requested a review from Yuri05 March 4, 2025 13:04
@rwmcintosh rwmcintosh merged commit 22a1b71 into develop Mar 4, 2025
1 check passed
@rwmcintosh rwmcintosh deleted the 2979-update-3rd-party-components-to-latest branch March 4, 2025 15:31
@github-project-automation github-project-automation bot moved this to Done in v12.1 Mar 4, 2025
@Yuri05 Yuri05 moved this from Done to Verified in v12.1 Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Verified

Development

Successfully merging this pull request may close these issues.

Update 3rd party components to latest

3 participants