Merged
Conversation
rwmcintosh
commented
Jun 2, 2025
| <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile> | ||
| <NoWarn>1591</NoWarn> | ||
| <Version Condition="'$(Version)' == ''">12.1.0</Version> | ||
| <GenerateResourceUsePreserializedResources>true</GenerateResourceUsePreserializedResources> |
Member
Author
There was a problem hiding this comment.
This consolidates how binary resources are serialized into the DLL. If you don't have it in csproj file then msbuild uses an older method of serializing binary data into dll and dotnet build will not work at all.
That means that no matter how you build (either through msbuild or dotnet build) you get the same result.
Yuri05
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the dependency on msbuild so that we can skip it for CI builds. It seems like the latest github hosted runners have a mismatch where there's a newer SDK installed compared to the version of Visual Studio making it impossible to build unless you specify the exact SDK to use.
But that means that devs all need to have the same version of Visual Studio at all times and this must be updated in lock-step with the CI updates. :(