Skip to content

Fixes #3137 Pull snapshot supporting classes to OSPSuite.Core for use in MoBi#3138

Merged
rwmcintosh merged 3 commits intoV13from
3137-pull-snapshot-supporting-classes-to-ospsuitecore-for-use-in-mobi
Jun 9, 2025
Merged

Fixes #3137 Pull snapshot supporting classes to OSPSuite.Core for use in MoBi#3138
rwmcintosh merged 3 commits intoV13from
3137-pull-snapshot-supporting-classes-to-ospsuitecore-for-use-in-mobi

Conversation

@rwmcintosh
Copy link
Copy Markdown
Member

Fixes #3137

Description

Things moved from PK-Sim to Core and a lot of using and churn results from that.

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):
    task

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

@rwmcintosh rwmcintosh self-assigned this Jun 5, 2025
@rwmcintosh rwmcintosh added this to v13 Jun 5, 2025
Comment on lines +68 to +73
container.AddScanner(scan =>
{
scan.AssemblyContainingType<CoreRegister>();
scan.IncludeNamespaceContainingType<ExpressionProfileMapper>();
scan.WithConvention<RegisterTypeConvention<ISnapshotMapperSpecification>>();
});
Copy link
Copy Markdown
Member Author

@rwmcintosh rwmcintosh Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to work because of the PKSimRegistrationConvention. But since the interface moved to Core, this had to be converted to explicit registration to satisfy repository convention

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that's the only non-refactor, non-move, non-spacing change.

@rwmcintosh rwmcintosh closed this Jun 5, 2025
@github-project-automation github-project-automation bot moved this to Done in v13 Jun 5, 2025
@rwmcintosh rwmcintosh reopened this Jun 5, 2025
@rwmcintosh rwmcintosh merged commit e008aed into V13 Jun 9, 2025
1 of 4 checks passed
@rwmcintosh rwmcintosh deleted the 3137-pull-snapshot-supporting-classes-to-ospsuitecore-for-use-in-mobi branch June 9, 2025 12:47
@Yuri05 Yuri05 moved this from Done to Verified in v13 Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Verified

Development

Successfully merging this pull request may close these issues.

2 participants