Conversation
* Fixes #3081 build on github * update package versions * update dependencies for resolver project * update readme * remove version * spacing * include runtime identifier * enable coverage for debugging * remove matlab tests from coverage * enable nightly for debugging * temporarily disable time check * remove tests temporarily * use nuget to restore * typos * typo * remove command chaining * quote * pk-sim * remove temporaries * postclean 12.1 * nuget restore
…op-branch' of https://github.com/Open-Systems-Pharmacology/PK-Sim into V3-1799-Pending-Issues-when-12.1-Core-merges-into-develop-branch
…ng-Issues-when-12.1-Core-merges-into-develop-branch V3-1799 UpdateParameterIdentification Using
Fixes #3114 Fix permissions in build-nightly.yml
…2.1.94 update core
…g from snapshot created with ≤ V11 (Simulations and PIs)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares version 12.1 for release by merging the develop branch to master. The changes encompass significant dependency updates, enhanced simulation management features, and improvements to code organization and configuration.
- Major version upgrade from 12.0 to 12.1 with comprehensive NuGet package updates
- Enhanced simulation execution management with improved cancellation and status tracking
- Code modernization including CI/CD migration from AppVeyor to GitHub Actions
Reviewed Changes
Copilot reviewed 134 out of 137 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| PKSim.sln | Added GitHub Actions workflow configurations |
| tests/**/*.csproj | Updated NuGet package versions and added version configuration |
| src/**/*.csproj | Updated to version 12.1.0 and upgraded dependencies |
| src/PKSim.Presentation/UICommands/StopSimulationCommand.cs | Changed from IUICommand to ActiveObjectUICommand with simulation-specific stopping |
| src/PKSim.Core/Services/InteractiveSimulationRunner.cs | Added concurrent simulation management and cancellation support |
| src/PKSim.Core/Services/SimulationRunner.cs | Added CancellationToken support to simulation execution |
| appveyor*.yml | Removed AppVeyor configuration files |
| .github/workflows/*.yml | Added GitHub Actions workflows for build, test, and deployment |
Files not reviewed (1)
- src/PKSim.Assets.Images/Images.Designer.cs: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rwmcintosh
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge develop ➡️ master before release.
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
Questions (if appropriate):