Conversation
* update 12.2 -> 12.3 * fix minor * update core * file naming
Co-authored-by: Yuri05 <25061876+Yuri05@users.noreply.github.com>
…l modification Co-authored-by: Yuri05 <25061876+Yuri05@users.noreply.github.com>
…e-test-log-upload-condition Always upload test log artifacts in nightly builds, even when tests fail
There was a problem hiding this comment.
Pull request overview
This PR updates the PKSim project from version 12.2 to 12.3, including package references, workflow configurations, and project metadata. The PR title indicates this is a test change not intended for merging.
Changes:
- Version numbers updated from 12.2.0 to 12.3.0 across all project files
- OSPSuite package references updated from 12.2.26 to 12.3.1
- GitHub Actions workflow files renamed and updated to reference version 12.3
- Build and test workflows consolidated and simplified
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/PKSim.UI.Tests/PKSim.UI.Tests.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| tests/PKSim.Tests/PKSim.Tests.csproj | Updated version to 12.3.0 and OSPSuite.Core to 12.3.1 |
| tests/PKSim.R.Tests/PKSim.R.Tests.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSimRDependencyResolution/PKSimRDependencyResolution.csproj | Updated version to 12.3.0 and OSPSuite.R to 12.3.1 |
| src/PKSim/PKSim.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.UI/PKSim.UI.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.UI.Starter/PKSim.UI.Starter.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.R/PKSim.R.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.Presentation/PKSim.Presentation.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.Infrastructure/PKSim.Infrastructure.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.Core/PKSim.Core.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.CLI/PKSim.CLI.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.CLI.Core/PKSim.CLI.Core.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.BatchTool/PKSim.BatchTool.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.Assets/PKSim.Assets.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| src/PKSim.Assets.Images/PKSim.Assets.Images.csproj | Updated version to 12.3.0 and OSPSuite packages to 12.3.1 |
| rakefile.rb | Updated application directory path from '12.2' to '12.3' |
| README.md | Updated workflow reference from build-nightly_12.2.yml to build-nightly_12.3.yml |
| PKSim.sln | Updated Visual Studio version and workflow file references |
| .github/workflows/nightly-badge.yml | Updated workflow name references from 12.2 to 12.3 |
| .github/workflows/coverage.yml | Updated build version from 12.2.9999 to 12.3.9999 |
| .github/workflows/build-nightly_12.3.yml | Renamed from 12.2 version, updated version references and simplified build commands |
| .github/workflows/build-and-test_12.2.yml | Removed (consolidated into build-and-test.yml) |
| .github/workflows/build-and-test.yml | New consolidated workflow for version 12.3 |
| .github/workflows/build-and-test-pr_12.2.yml | Removed (consolidated into build-and-test.yml) |
Comments suppressed due to low confidence (1)
.github/workflows/build-nightly_12.3.yml:120
- The
if: always()condition on the test log upload step is a good practice to ensure logs are uploaded even when tests fail. This change improves debugging capabilities.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryThis PR upgrades the project from version 12.2 to 12.3 across all configuration files, workflows, and project dependencies. Key Changes:
Note: The PR title states "Test - don't merge" indicating this is intended for testing purposes only and should not be merged to the base branch. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR as Pull Request #3377
participant GHA as GitHub Actions
participant Workflows as OSP Workflows Repo
participant Deps as Package Dependencies
Dev->>PR: Push version upgrade changes (12.2 → 12.3)
Note over PR: Update workflow files
PR->>GHA: Delete old 12.2 workflows
PR->>GHA: Create simplified build-and-test.yml
PR->>GHA: Rename/update build-nightly to 12.3
PR->>GHA: Update coverage.yml and nightly-badge.yml
Note over PR: Update project files (25 files)
PR->>Deps: Update default version to 12.3.0
PR->>Deps: Upgrade OSPSuite packages (12.2.26 → 12.3.1)
Note over PR: Update configuration
PR->>PR: Update rakefile.rb application path
PR->>PR: Update README.md badge link
PR->>PR: Update PKSim.sln VS version
alt On Pull Request or Push to develop
GHA->>Workflows: Call test-csharp.yml@main
Workflows->>GHA: Execute standardized build & test
GHA->>GHA: Run tests with version 12.3.9999
end
alt On Nightly Build (if recent commits)
GHA->>GHA: Check latest commit timespan
GHA->>GHA: Build with version 12.3.{run_number}
GHA->>GHA: Run tests (upload logs with if: always())
GHA->>GHA: Sign executables
GHA->>GHA: Create and upload artifacts
end
|
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
|
This graph lol 😝 |
Fixes #
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
Questions (if appropriate):