[claude-opus-4.6] Add more tests for the new PBBM implementation#3415
Draft
[claude-opus-4.6] Add more tests for the new PBBM implementation#3415
Conversation
Co-authored-by: Yuri05 <25061876+Yuri05@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add integration tests for PBBM implementation
Add integration tests for PBBM particle dissolution model options
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive integration test coverage for the new PBBM (Physiologically-Based Biopharmaceutics Modeling) model options introduced in PR #3399. The original PR added three new model toggles (hydrodynamic model, effective diffusion, and Hintz-Johnson) but only tested them in non-precipitation scenarios with 2-bin formulations. These new tests fill the coverage gaps by testing precipitation scenarios, single-bin formulations, and combined model option configurations.
Changes:
- Added 7 new integration test classes covering precipitation scenarios with each model option toggle
- Added tests for combined model options (all three toggles used simultaneously)
- Added single-bin formulation tests with model option toggles
- Added test for interaction between effective diffusion and hydrodynamic model options
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3399 introduced new PBBM model toggles (hydrodynamic model, effective diffusion, Hintz-Johnson) but only tested them in non-precipitation scenarios with 2-bin formulations. This adds coverage for the missing combinations.
New test classes (8)
All tests follow the existing
concern_for_SimulationWithParticlesFormulationBDD pattern:Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.