-
Notifications
You must be signed in to change notification settings - Fork 7
Fixes #536 watermark position independent from scales #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #536 watermark position independent from scales #537
Conversation
|
@KatrinCoboeken is this already accounted for in |
I checked, you actually use |
Felixmil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshots need to be updated too.
|
Yes, in {ospsuite.plots} I also had to update the watermark feature with ggplot2 version 4. But it is done. |
Felixmil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plots look the same, the changes are svg "internal". All good.
|
Should we expect plot changes in other packages ? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #537 +/- ##
============================================
+ Coverage 71.26% 84.24% +12.98%
============================================
Files 63 63
Lines 4326 11033 +6707
============================================
+ Hits 3083 9295 +6212
- Misses 1243 1738 +495 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This update should not change the plots in other packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issue #536 by making watermark positioning independent from plot scales, following the approach suggested in ggplot2 PR #6182. The fix wraps the infinite boundary values with I() to prevent them from being affected by scale transformations.
Key Changes:
- Wrapped
annotation_custom()boundary parameters withI()to ensure scale-independent positioning - Fixed a typo in layer access (
layer→layers)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
As suggested in this
ggplot2PR