-
Notifications
You must be signed in to change notification settings - Fork 47
Fix title fields for EGS entries #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Redout: Enhanced Edition,egs,1be5efb848844b1dabf9d67f8017a7ae,umu-517710,, | ||
| Fallout: New Vegas Ultimate Edition,gog,1454587428,umu-22380,FNV, | ||
| Fallout: New Vegas Ultimate Edition,egs,3428aaab2c674c98b3acb789dcfaa548,umu-22380,FNV, | ||
| Fallout: New Vegas,egs,3428aaab2c674c98b3acb789dcfaa548,umu-22380,FNV, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry uses a Namespace instead of an AppName, so it refers to a collection rather a specific game. https://egdata.app/offers/08834851d4a54f48b485e97caab98012/builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Fallout: New Vegas, the AppName is 5daeb974a22a435988892319b3a4f476 not 3428aaab2c674c98b3acb789dcfaa548, making HGL not pick up the correct fix for this at all. https://egdata.app/offers/68282d75318a4e47b5bacf1994f648d3
Note: This isn't the only entry with an incorrect AppName field. Fixing those entries with the wrong AppName will be settled in separate pull request.
For EGS games, we currently guide users to go to egdata.app to determine and use the correct fields when creating database entries. However, currently, some of our current EGS entries have title names that are incorrect due to missing characters (e.g., ™) making those entries invalid. For those entries, prefer maintaining the title's integrity by using the title from game's item page on egdata.app.
8f42609 to
52b7b46
Compare
For EGS games, we currently guide users to go to egdata.app to determine and use the correct fields when creating database entries. However, currently, some of our current EGS entries have title names that are incorrect due to missing characters (e.g., ™) making those entries invalid. For those entries, prefer maintaining the title's integrity by using the title from game's item page on egdata.app.