Only consider umu setup if there are files in .local/share/umu/ #589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When umu starts downloading the runtime required for the specified tool, it will create a folder for it in UMU_LOCAL. If this download fails, the following code is supposed to catch the error, explain it, and stop the launch:
umu-launcher/umu/umu_run.py
Lines 888 to 894 in 24cdc86
However,
has_umu_setupcurrently only checks whether there is any non-lock file/folder in UMU_LOCAL, meaning the empty runtime directory that was created gets found, and umu is considered "setup".With this PR, we instead search for non-lock files (not folders) in UMU_LOCAL, which avoids the above issue