Skip to content

Conversation

@Kroustille
Copy link
Contributor

Proposed changes

  • reset registration data when platform is not found on the hub
  • refactor how connectivity lost email is handled

Testing Instructions

  1. register platform on the hub
  2. remove platform in the hub
  3. check that registration is removed after connectivity check

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kroustille Kroustille self-assigned this Nov 26, 2025
@Kroustille Kroustille added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Nov 26, 2025
@Kroustille Kroustille changed the title [backend] feat: reset XTM Hub registration when platform is not found [backend] feat: reset XTM Hub registration when platform is not found (#4441) Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.11%. Comparing base (b361d2d) to head (92bf55f).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...a/io/openaev/xtmhub/XtmHubConnectivityService.java 40.00% 5 Missing and 1 partial ⚠️
.../src/main/java/io/openaev/xtmhub/XtmHubClient.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4442      +/-   ##
============================================
- Coverage     50.13%   50.11%   -0.02%     
+ Complexity     3639     3637       -2     
============================================
  Files           896      896              
  Lines         26560    26576      +16     
  Branches       1989     1991       +2     
============================================
+ Hits          13316    13319       +3     
- Misses        12445    12457      +12     
- Partials        799      800       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@savacano28 savacano28 removed the bug use for describing something not working as expected label Nov 26, 2025
@savacano28
Copy link
Contributor

savacano28 commented Dec 1, 2025

Tested OK!

@Kroustille Kroustille merged commit 99bd6b4 into master Dec 2, 2025
12 checks passed
@Kroustille Kroustille deleted the issue/4441 branch December 2, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants