Skip to content

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jan 11, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

details

This is fixing problems found using https://crates.io/crates/typos-cli

my WIP config is roughly

[default]
extend-ignore-re = [
  "DES-EDE3-CBC",
  "Ha Minh Nam",
  "cpp-ue4",
  "CppUE4",
  "PNGs",
  "UE_LOG",
  "NamSor",
]

[default.extend-words]
Paket = "Paket"
vertx = "vertx"
verticle = "verticle"
byt = "byt"
EIS = "EIS"
ono = "ono"
Tye = "Tye"
Robocorp = "Robocorp"
ags = "ags"

[default.extend-identifiers]
testng = "testng"
ser = "ser"
opf = "opf"

@jayvdb jayvdb marked this pull request as ready for review January 11, 2025 06:08
for(var prompt in currentNode){
if (currentNode.hasOwnProperty(prompt)) {
currentChild = currentNode[prompt]
if (id == prompt) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be property instead of prompt/propt as it stands for property

i will take care of it in another PR

@wing328 wing328 merged commit eb47b9d into OpenAPITools:master Jan 11, 2025
16 checks passed
@wing328 wing328 mentioned this pull request Jan 11, 2025
5 tasks
@jayvdb jayvdb deleted the typos branch January 11, 2025 08:12
@wing328 wing328 added this to the 7.11.0 milestone Jan 20, 2025
timon-sbr pushed a commit to timon-sbr/openapi-generator that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants