Skip to content

Fixup failing CI in rust-server due to xmltree dependency #21664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025

Conversation

dsteeley
Copy link
Contributor

@dsteeley dsteeley commented Jul 30, 2025

The rust-server and rust-server-deprecated depend on serde-xml-rs. This PR updates from a historic fork to the released version. I have replaced the unmerged changes with an appropriate alternative that gives the same function.

to_string_with_namespaces => Use the clear namespace support in the latest serde-xml-rs
wrap_primitives => Uplift the function in forked serde-xml-rs here as this change isn't going to be merged into the upstream crate.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description) Fixes issue raised inhttps://github.com/trigger build #21608
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10) @dsteeley (2025/07)

@dsteeley dsteeley changed the title Fixup xmltree Fixup failing CI in rust-server due to xmltree dependency Jul 31, 2025
@dsteeley dsteeley marked this pull request as ready for review July 31, 2025 14:54
@dsteeley dsteeley mentioned this pull request Jul 31, 2025
5 tasks
@wing328 wing328 merged commit 97aa4a8 into OpenAPITools:master Aug 1, 2025
20 checks passed
@wing328 wing328 added this to the 7.15.0 milestone Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants