Skip to content

[PHP] Fix type casting in HeaderSelector::getHeaderAndWeight #21685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Aug 2, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@szepeviktor
Copy link
Contributor Author

PHPStan said

 ------ -----------------------------------------------------------------------------
  Line   HeaderSelector.php
 ------ -----------------------------------------------------------------------------
  154    Binary operation "*" between non-falsy-string and 1000 results in an error.
         🪪  binaryOp.invalid
 ------ -----------------------------------------------------------------------------

@szepeviktor szepeviktor changed the title Fix type casting in HeaderSelector::getHeaderAndWeight [PHP] Fix type casting in HeaderSelector::getHeaderAndWeight Aug 2, 2025
@szepeviktor szepeviktor marked this pull request as ready for review August 2, 2025 09:11
@wing328
Copy link
Member

wing328 commented Aug 2, 2025

thanks for the pr

please follow step 3 to update the samples

@szepeviktor
Copy link
Contributor Author

Here you go.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Aug 2, 2025

Do we have rounding problems now?

@wing328
Copy link
Member

wing328 commented Aug 2, 2025

according to ci build results, i think so

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Aug 2, 2025

I am double zero in this field. Please help me what command to issue.

I wish you could add a commit to this PR. I have random Java exceptions.

@szepeviktor
Copy link
Contributor Author

I see! That value is really a float.
So rounding it to an int produces a different result!

@szepeviktor szepeviktor marked this pull request as draft August 2, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants