Skip to content

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Oct 16, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title update ts angualr v17 tests with the correct versions Update TS Angualr v17, v18, v20 tests with the correct versions Oct 16, 2025
@wing328 wing328 changed the title Update TS Angualr v17, v18, v20 tests with the correct versions Update TS Angular v20 tests with the correct versions Oct 16, 2025
@wing328 wing328 added this to the 7.17.0 milestone Oct 16, 2025
@wing328 wing328 changed the title Update TS Angular v20 tests with the correct versions Update TS Angular v17, v18 tests with the correct versions Oct 16, 2025
@wing328
Copy link
Member Author

wing328 commented Oct 16, 2025

will put this on hold unless someone has time to fix it by updating the tests to work with older versions of angular (v17, v18)

given that v18 was release 1 year ago ((May 2024), this change is not something with the highest priority but still we welcome PR to fix the tests to work older versions of Angular.

@wing328
Copy link
Member Author

wing328 commented Oct 16, 2025

here is the (partial) error message in case the logs are deleted later:

Chrome Headless 140.0.0.0 (Linux 0.0.0): Executed 17 of 23 SUCCESS (0 secs / 0.044 secs)
Chrome Headless 140.0.0.0 (Linux 0.0.0) AppComponent constructor() should have a userService provided FAILED
	Error: Unexpected directive 'AppComponent' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.
	    at verifySemanticsOfNgModuleImport (node_modules/@angular/core/fesm2022/core.mjs:28987:19)
	    at forEach (node_modules/@angular/core/fesm2022/core.mjs:28884:9)
	    at Array.forEach (<anonymous>)
	    at verifySemanticsOfNgModuleDef (node_modules/@angular/core/fesm2022/core.mjs:28883:60)
	    at DynamicTestModule.get (node_modules/@angular/core/fesm2022/core.mjs:28836:30)
	    at TestBedCompiler.applyProviderOverridesInScope (node_modules/@angular/core/fesm2022/testing.mjs:1173:33)
	    at TestBedCompiler.compileTestModule (node_modules/@angular/core/fesm2022/testing.mjs:1477:14)
	    at TestBedCompiler.finalize (node_modules/@angular/core/fesm2022/testing.mjs:998:14)
	    at TestBedImpl.testModuleRef (node_modules/@angular/core/fesm2022/testing.mjs:2010:49)
	    at TestBedImpl.inject (node_modules/@angular/core/fesm2022/testing.mjs:1914:29)
Chrome Headless 140.0.0.0 (Linux 0.0.0): Executed 18 of 23 (1 FAILED) (0 secs / 0.08 secs)
Chrome Headless 140.0.0.0 (Linux 0.0.0) AppComponent constructor() should have a userService provided FAILED
	Error: Unexpected directive 'AppComponent' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.
	    at verifySemanticsOfNgModuleImport (node_modules/@angular/core/fesm2022/core.mjs:28987:19)
	    at forEach (node_modules/@angular/core/fesm2022/core.mjs:28884:9)
	    at Array.forEach (<anonymous>)
	    at verifySemanticsOfNgModuleDef (node_modules/@angular/core/fesm2022/core.mjs:28883:60)
	    at DynamicTestModule.get (node_modules/@angular/core/fesm2022/core.mjs:28836:30)
	    at TestBedCompiler.applyProviderOverridesInScope (node_modules/@angular/core/fesm2022/testing.mjs:1173:33)
	    at TestBedCompiler.compileTestModule (node_modules/@angular/core/fesm2022/testing.mjs:1477:14)
	    at TestBedCompiler.finalize (node_modules/@angular/core/fesm2022/testing.mjs:998:14)
	    at TestBedImpl.testModuleRef (node_modules/@angular/core/fesm2022/testing.mjs:2010:49)
	    at TestBedImpl.inject (node_modules/@angular/core/fesm2022/testing.mjs:1914:29)
Chrome Headless 140.0.0.0 (Linux 0.0.0) AppComponent constructor() should have a storeService provided FAILED

@macjohnny
Copy link
Member

if its too much work, i would simply abandon all tests for angular < 20 or 19, just make sure the most up to date version still has tests

@wing328
Copy link
Member Author

wing328 commented Oct 16, 2025

right. let's see if there're any "demands" for angular v17, v18 in particular.

if none, we will drop these tests later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants