-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Update TS Angular v17, v18 tests with the correct versions #22154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
will put this on hold unless someone has time to fix it by updating the tests to work with older versions of angular (v17, v18) given that v18 was release 1 year ago ((May 2024), this change is not something with the highest priority but still we welcome PR to fix the tests to work older versions of Angular. |
here is the (partial) error message in case the logs are deleted later:
|
if its too much work, i would simply abandon all tests for angular < 20 or 19, just make sure the most up to date version still has tests |
right. let's see if there're any "demands" for angular v17, v18 in particular. if none, we will drop these tests later. |
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)"fixes #123"
present in the PR description)