[rust-axum] don't include quotes in output string from Display trait for string types #22161
+11
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of a minor breaking change but I think it's still a breaking change, so I put it against
8.0.x
. Let me know if you think otherwise.cc @linxGnu
When generating Rust types for an object defined in the OpenAPI spec as
type: string
, the generated struct is a 1-tuple with theDisplay
trait using the debug formatting (i.e."{:?}"
). This causes calls toto_string
to output the value with quotes in the string.Example:
The above schema generates the following type
and if I call
to_string
on aRegion
, I will get the value with quotesIf we change the format string to just
"{}"
, thento_string
results in a properly formatted string.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)"fixes #123"
present in the PR description)