Skip to content

Conversation

zhornback
Copy link
Contributor

Make use of helpful code added in
243f501 to skip sorting of path parameters. In FastAPI, order matters, see link for details: https://fastapi.tiangolo.com/tutorial/path-params/?h=path#order-matters

fixes #22163

Modified FastAPI's configuration, setting setSkipSortingOperations to True so FastAPI path operations will not be reordered.

PR checklist

  • [ X ] Read the contribution guidelines.
  • [ X ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ X ] Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [ X ] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ X ] If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • [ X ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…2163)

Make use of helpful code added in
243f501 to skip sorting of path
parameters.  In FastAPI, order matters, see link for details:
https://fastapi.tiangolo.com/tutorial/path-params/?h=path#order-matters

Issue: OpenAPITools#22163
@wing328
Copy link
Member

wing328 commented Oct 17, 2025

thanks for the PR

can you please follow step 3 to update the samples?

Reading comprehension is hard.  I missed the part of step 3 where
samples would be updated in response to the change I had previous
submitted.

Via this commit, update samples to match expectations.  The order of
various endpoint implementations is now changed in the sample, matchcing
the order in the yaml files that created them.
@zhornback
Copy link
Contributor Author

My apologies for the oversight. I believe it is corrected now.

@wing328 wing328 merged commit ccd43a5 into OpenAPITools:master Oct 18, 2025
12 checks passed
@wing328
Copy link
Member

wing328 commented Oct 18, 2025

thanks for the fix, which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][python-fastapi] Reordering of path operations can cause issues when path parameters are involved

2 participants