-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[nim] Nim Generator Fixes #22385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
winrid
wants to merge
6
commits into
OpenAPITools:master
Choose a base branch
from
winrid:nim-working-version-fastcomments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[nim] Nim Generator Fixes #22385
winrid
wants to merge
6
commits into
OpenAPITools:master
from
winrid:nim-working-version-fastcomments
+1,804
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Contributor
|
Thank you so much for your fix @winrid ! |
Member
|
I'll run some tests later this week If no issue found, I'll merge it. |
…URLs, support oneOf/anyOf via nim object variants, optional field support
Contributor
Author
|
added:
|
Contributor
Author
|
I think there is a bug with fields like |
Contributor
Author
|
Okay, now it's ready for review :) That got kind of wild to support nim's type system, but it works, and cleans up the generated models some. Enums now also support integer ordinals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally I prefer more targeted PRs, but the Nim generator needed a lot of fixes to be usable for me, so here they are :)
@wing328