fix: missing imports for array of files and date-time parameters #22390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the Go code generator to correctly add necessary imports when operations or webhooks use array parameters of binary files or date-time types. It also adds new tests to verify this behavior. The main changes are in the logic for determining imports and in the test coverage. Fixes #22389
Import logic improvements
AbstractGoCodegen.javato add the"os"import if any parameter is an array of binary files (*os.File), and the"time"import if any parameter is an array of date-time values (time.Time) in bothpostProcessOperationsWithModelsandpostProcessWebhooksWithModelsmethods. [1] [2]Test coverage
AbstractGoCodegenTest.javato verify that the"os"import is added for array of binary file parameters and the"time"import is added for array of date-time parameters in operations.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)