Skip to content

Conversation

@ricardogrande-masmovil
Copy link

This pull request improves the Go code generator to correctly add necessary imports when operations or webhooks use array parameters of binary files or date-time types. It also adds new tests to verify this behavior. The main changes are in the logic for determining imports and in the test coverage. Fixes #22389

Import logic improvements

  • Updated AbstractGoCodegen.java to add the "os" import if any parameter is an array of binary files (*os.File), and the "time" import if any parameter is an array of date-time values (time.Time) in both postProcessOperationsWithModels and postProcessWebhooksWithModels methods. [1] [2]

Test coverage

  • Added new tests in AbstractGoCodegenTest.java to verify that the "os" import is added for array of binary file parameters and the "time" import is added for array of date-time parameters in operations.
  • Included additional imports in the test file to support new test cases.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)

@ricardogrande-masmovil ricardogrande-masmovil changed the title fix: missing imports for array of files and date-time parameters (#1) fix: missing imports for array of files and date-time parameters Nov 19, 2025
@ricardogrande-masmovil
Copy link
Author

Not a java expert at all, so please let me know if I should refactor the tests in any way! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Go] Missing imports for array of files and date-time parameters

1 participant